deps: x/net 0.57.0 -> 0.58.0 (supersedes #181) - #203
Merged
Conversation
Supersedes the stale dependabot PR #181, which proposed 0.55.0 -- three minor versions behind by the time it was looked at, and by now a downgrade: merging miekg/dns 1.1.73 (#186) pulled x/net from 0.54.0 to 0.57.0 transitively. That transitive bump also removed the one reason #181 mattered. x/net 0.54.0 carried GO-2026-5026, a failure to reject ASCII-only Punycode-encoded labels in x/net/idna, and govulncheck placed it in the CALLED set rather than among the imported-but-unreachable ones. It is fixed in 0.55.0, so main was already clear of it before this commit. This is hygiene: be at the current version, and stop dependabot reopening the same PR. x/text comes along because go mod tidy resolves it with x/net. Both packages are indirect dependencies. govulncheck on the result reports 16 called vulnerabilities, all of them in the Go standard library and none in any module this repository requires -- see the PR for why that is worth its own look.
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #181.
Why not just merge #181
#181 proposed x/net 0.54.0 → 0.55.0. It was opened on 2 July and the current release is 0.58.0, so it was three minor versions stale — and after merging #186 it became a downgrade: miekg/dns 1.1.73 pulled x/net from 0.54.0 to 0.57.0 transitively. Merging #181 now would move x/net backwards, and dependabot would immediately reopen for 0.58.0 anyway.
What #181 was actually about
Worth recording, because it was not noise. x/net 0.54.0 carried GO-2026-5026 — failure to reject ASCII-only Punycode-encoded labels in
x/net/idna— and govulncheck placed it in the called set, not among the imported-but-unreachable findings. It had been sitting in the backlog since 2 July.It is fixed in 0.55.0, so the #186 merge cleared it incidentally. Verified: at 0.54.0 the called set had 17 findings, one attributed to
golang.org/x/net@v0.54.0; on main now it is 16, all standard library.So this PR is hygiene rather than a fix: be at the current version, and stop the same PR reappearing.
x/text0.40.0 → 0.41.0 comes along becausego mod tidyresolves it with x/net. Both are indirect dependencies; no source changes.Verification
go build,go vet, and the full suite with-raceincluding the rig — green.Separate finding, not addressed here
govulncheck reports 16 called vulnerabilities from the Go standard library —
crypto/x509,crypto/tls,net/http,net/mail,encoding/asn1— and none from any module this repository requires. No dependency bump touches that; it is the toolchain.One caveat before acting on the number: that scan ran with go1.26.1 locally, and the advisories point at go1.26.2/1.26.4, while
go.moddeclaresgo 1.25.0and CI resolves its toolchain fromgo.mod. pop's real CI exposure is whatever 1.25.x carries, which I have not measured. Worth its own look; deliberately kept out of this PR.