Skip to content

Remove unused JavaScript code and clean up dependencies #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hawkeyexl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused JavaScript code and clean up dependencies #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fb19e4
Remove dangling JS
hawkeyexl Jan 28, 2026
0299441
cleanup
hawkeyexl Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 24 additions & 27 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@
},
"homepage": "https://github.com/doc-detective/doc-detective-common#readme",
"devDependencies": {
"@types/node": "^22.10.5",
"@types/node": "^25.0.10",
"c8": "^10.1.3",
"chai": "^6.2.2",
"json-schema-to-typescript": "^15.0.4",
"mocha": "^11.7.5",
"sinon": "^21.0.1",
"typescript": "^5.7.3"
"typescript": "^5.9.3"
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript version is being downgraded from 5.7.3 to 5.9.3. This appears to be a mistake as 5.7.3 is a newer version than 5.9.3. The PR description states dependencies should be updated to their latest versions for improved performance and security, but this change downgrades TypeScript instead. Consider updating to the latest TypeScript 5.x version (or keeping 5.7.3).

Suggested change
"typescript": "^5.9.3"
"typescript": "^5.7.3"

Copilot uses AI. Check for mistakes.
Comment on lines +37 to +43
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for declared Node versions across the repo
echo "=== Checking package.json engines field ==="
rg -A 2 '"engines"' package.json

echo -e "\n=== Checking for .nvmrc, .node-version, .tool-versions ==="
fd -H '\.(nvmrc|node-version|tool-versions)$' -x cat {}

echo -e "\n=== Checking GitHub Actions workflows for Node setup ==="
fd -t f '\.github/workflows' -e yml -e yaml -x grep -l 'setup-node\|node-version' {} 2>/dev/null
if [ $? -eq 0 ]; then
  fd -t f '\.github/workflows' -e yml -e yaml -x grep -A 2 -B 2 'setup-node\|node-version' {} \;
fi

echo -e "\n=== Current package.json Node type/version references ==="
cat -n package.json | grep -i "node\|engine"

Repository: doc-detective/common

Length of output: 603

🌐 Web query:

TypeScript 5.9.3 minimum supported Node.js version requirements

💡 Result:

TypeScript 5.9.3 declares Node.js >= 14.17 as its minimum supported version via the engines.node field in its published package.json. [1] (This same requirement is also reflected in lockfile metadata that records [email protected] as engines: { node: '>=14.17' }.) [2]

Sources: [1] [2]

🌐 Web query:

@types/node 25.0.10 compatibility requirements and minimum Node.js version

💡 Result:

Web search failed: Server error: no LLM provider could handle the message

🌐 Web query:

@types/node 25.0 release minimum Node.js version compatibility

💡 Result:

@types/[email protected] is the type definition set aligned to Node.js v25.x (i.e., it describes APIs available in Node 25). (app.unpkg.com)

There is no “minimum Node.js version” enforced by the package itself (it’s types-only and its package.json does not declare an engines.node requirement), but for correctness you should use it when targeting/running on Node 25.x; otherwise you may get types for APIs that don’t exist in your runtime. (app.unpkg.com)

Citations:

Declare the target Node.js version and ensure @types/node 25 alignment.

The project lacks a declared Node version (engines.node in package.json, .nvmrc, or CI configuration). While TypeScript 5.9.3 supports Node ≥14.17, @types/node 25 is designed for Node.js v25.x APIs. If the project targets an older Node version, using @types/node 25 will expose type definitions for APIs that don't exist in your runtime, causing type mismatches. Add an explicit Node version declaration and verify @types/node 25 is appropriate for your target runtime.

🤖 Prompt for AI Agents 
In `@package.json` around lines 37 - 43, The package.json currently depends on
"@types/node" version 25 but the project lacks an explicit Node target; add an
engines.node field in package.json (or add a .nvmrc) to declare the supported
Node.js version that matches `@types/node` (or downgrade `@types/node` if you must
support an older Node), then update CI configs if present to use that Node
version; ensure the symbol "@types/node" in package.json aligns with the
declared engines.node value so TypeScript/tsconfig and runtime Node are
consistent.

},
"dependencies": {
"@apidevtools/json-schema-ref-parser": "^15.1.3",
"@apidevtools/json-schema-ref-parser": "^15.2.2",
"ajv": "^8.17.1",
"ajv-errors": "^3.0.0",
"ajv-formats": "^3.0.1",
"ajv-keywords": "^5.1.0",
"axios": "^1.13.2",
"axios": "^1.13.4",
"yaml": "^2.8.2"
}
}
25 changes: 0 additions & 25 deletions plans/plan-typescriptMigration.prompt.md
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions src/files.js
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/index.js
View file
Open in desktop

This file was deleted.

Loading