Fix WS001 false positive with bold syntax (Issue #41)#44
Merged
rdmueller merged 1 commit intodocToolchain:mainfrom Feb 12, 2026
Merged
Conversation
…ocToolchain#41) WS001 was incorrectly flagging AsciiDoc bold syntax (*text* and **text**) as list markers missing a space. Added _is_bold_syntax() method to detect when asterisks are used for inline bold formatting rather than list markers, by checking for matching closing asterisks in the text. Closes docToolchain#41 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*text*,**text**) as list markers missing a space*as a potential list marker, without distinguishing inline bold formatting_is_bold_syntax()helper method that detects matching closing asterisks, indicating bold formatting rather than a list markerChanges
asciidoc_linter/rules/whitespace_rules.py_is_bold_syntax(self, stripped)method toWhitespaceRuletests/rules/test_whitespace_rules.pyAdded 5 new test cases:
test_bold_syntax_not_flagged_as_list_marker—*Status:* Acceptedpattern (common in ADRs)test_double_bold_syntax_not_flagged_as_list_marker—**Positive:**patterntest_mid_line_bold_not_flagged— mid-line*bold*texttest_list_marker_without_space_still_flagged— ensures real*Itemviolations are still caughttest_valid_list_markers_not_flagged— ensures* itemremains validTest plan
*Status:*) no longer triggers WS001**Positive:**) no longer triggers WS001*Item) still correctly flagged* Item) remain unflaggedFixes #41
🤖 Generated with Claude Code