Skip to content

Update eclipse-temurin docs about CA certs on non-root images #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rassie
Copy link
Contributor

@rassie rassie commented May 10, 2024

Copy link
Contributor

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams
Copy link
Contributor

gdams commented May 29, 2024

CC @tianon @yosifkit can one of you merge this please?

Copy link
Contributor

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a link for creating an issue?

@tianon
Copy link
Member

tianon commented May 29, 2024

Is this change (adoptium/containers#538) part of (or even proposed to) the published images yet?
(I'm not seeing it in https://github.com/docker-library/official-images/issues?q=label%3Alibrary%2Feclipse-temurin 😬)

Also feeling some big echos of #2338 (comment) (continuing scope creep in what's otherwise a very generic image) that I'm really not thrilled about but probably way too late to adjust course now 😕

@rassie
Copy link
Contributor Author

rassie commented Jun 3, 2024

Added changes connected to adoptium/containers#572

@yosifkit
Copy link
Member

yosifkit commented May 6, 2025

🙇‍♂️ Sorry for the delay. Is this ready and applicable to the current images?

@rassie
Copy link
Contributor Author

rassie commented May 7, 2025

IIRC, the containers have long released with these changes, so it's good to go from where I'm standing. Maybe @gdams can give it a last look-over.

@gdams
Copy link
Contributor

gdams commented May 7, 2025

Still looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for CA certificate support changes
5 participants