Skip to content

fix: align vuejs README port mapping with actual behavior #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moinloin
Copy link

Fix: Align vuejs README port mapping with actual configuration

This pull request updates the vuejs/README.md to ensure consistency between the explanation and the docker-compose.yml example.

Changes made:

  • Updated the explanation text to reflect that port 8080 on the host is mapped to port 8080 in the container.
  • Updated the docker-compose.yml snippet to use "8080:8080" instead of "80:8080".

Why:

The previous example showed "80:8080", which didn't match the accompanying explanation or the actual behavior. This fix ensures clarity and avoids confusion for users following the guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant