check provenance attestation set in bake definition before overriding#359
Merged
crazy-max merged 2 commits intodocker:masterfrom Nov 27, 2025
Merged
check provenance attestation set in bake definition before overriding#359crazy-max merged 2 commits intodocker:masterfrom
crazy-max merged 2 commits intodocker:masterfrom
Conversation
crazy-max
force-pushed
the
check-attest-definition
branch
3 times, most recently
from
0d03cad to
03efd0a
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
check-attest-definition
branch
from
03efd0a to
597dc07
Compare
crazy-max
commented
Nov 26, 2025
Comment on lines
+1
to
+17
| group "default" { | ||
| targets = ["t1", "t2", "t3"] | ||
| } | ||
|
|
||
| target "t1" { | ||
| target = "t1" | ||
| } | ||
|
|
||
| target "t2" { | ||
| target = "t2" | ||
| attest = ["type=provenance,mode=min"] | ||
| } | ||
|
|
||
| target "t3" { | ||
| target = "t3" | ||
| attest = ["type=sbom"] | ||
| } |
Member
Author
There was a problem hiding this comment.
Tested in https://github.com/docker/bake-action/actions/runs/19702226697/job/56441006449#step:4:234
{
"group": {
"default": {
"targets": [
"t1",
"t2",
"t3"
]
}
},
"target": {
"t1": {
"attest": [
{
"builder-id": "https://github.com/docker/bake-action/actions/runs/19702226697/attempts/1",
"mode": "max",
"type": "provenance"
}
],
"context": ".",
"dockerfile": "Dockerfile",
"target": "t1"
},
"t2": {
"attest": [
{
"mode": "min",
"type": "provenance"
}
],
"context": ".",
"dockerfile": "Dockerfile",
"target": "t2"
},
"t3": {
"attest": [
{
"type": "sbom"
},
{
"builder-id": "https://github.com/docker/bake-action/actions/runs/19702226697/attempts/1",
"mode": "max",
"type": "provenance"
}
],
"context": ".",
"dockerfile": "Dockerfile",
"target": "t3"
}
}
}
tonistiigi
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #349
cc @marverix