Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bake v0.19 entitlements #2835

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Dec 3, 2024

  • docs(bake): improve docs on "call" and "description" in bake file
  • docs: add docs for bake --allow

@dvdksn dvdksn force-pushed the bake-v019-entitlements branch from 24d5319 to 642c778 Compare December 3, 2024 14:51
@dvdksn dvdksn marked this pull request as ready for review December 3, 2024 14:51
docs/reference/buildx_bake.md Outdated Show resolved Hide resolved
docs/reference/buildx_bake.md Show resolved Hide resolved
@dvdksn dvdksn force-pushed the bake-v019-entitlements branch from 642c778 to 26e6382 Compare December 18, 2024 10:15
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New entitlements content looks good

}
```

This attribute is useful when combined with the `targets` frontend method,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually targets frontend method, but bake --list-targets flag as these descriptions are for bake targets, not Dockerfile stages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@dvdksn dvdksn force-pushed the bake-v019-entitlements branch 2 times, most recently from 7203a37 to 8fc1070 Compare January 9, 2025 09:02
@dvdksn dvdksn requested a review from tonistiigi January 9, 2025 09:02
@dvdksn dvdksn force-pushed the bake-v019-entitlements branch from 8fc1070 to 1c6ec68 Compare January 13, 2025 10:13
@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 13, 2025

Updated from --list-targets to --list=targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants