Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: test secrets override #2912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 14, 2025

@crazy-max
Copy link
Member Author

crazy-max commented Jan 14, 2025

It doesn't append: https://github.com/docker/buildx/actions/runs/12768837294/job/35590048834?pr=2912#step:6:1346

 === FAIL: bake TestReadTargets/SecretsOverride (0.00s)
    bake_test.go:161: 
        	Error Trace:	/home/runner/work/buildx/buildx/bake/bake_test.go:161
        	Error:      	"[id=BAR,env=BAR]" should have 2 item(s), but has 1
        	Test:       	TestReadTargets/SecretsOverride
    --- FAIL: TestReadTargets/SecretsOverride (0.00s)

Looking at

buildx/bake/bake.go

Lines 928 to 933 in 1eb167a

case "secrets":
secrets, err := parseArrValue[buildflags.Secret](o.ArrValue)
if err != nil {
return errors.Wrap(err, "invalid value for outputs")
}
t.Secrets = secrets
it seems expected

@crazy-max crazy-max force-pushed the test-bake-secrets-override branch from 3056ab4 to 3090004 Compare January 14, 2025 14:13
@crazy-max crazy-max requested a review from tonistiigi January 14, 2025 14:56
@crazy-max crazy-max marked this pull request as ready for review January 14, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant