Fix panic in buildx debug when solving fails#3823
Merged
crazy-max merged 2 commits intodocker:masterfrom May 5, 2026
Merged
Conversation
crazy-max
requested changes
May 4, 2026
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Thanks! Guarding the mount/input result IDs before indexing looks good, since BuildKit can return a solve error for an exec op before all mount results are available.
The main thing I would change is the test direction. I would rather cover this with an integration test that uses a real Dockerfile reproducer, for example a RUN --mount=type=bind,source=missing,target=/src ... failure through buildx debug --on=error build.
This was referenced May 4, 2026
Closes docker#3822 Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
invidian
force-pushed
the
fix-result-error-handling
branch
from
7cdff4d to
9de08b2
Compare
crazy-max
approved these changes
May 4, 2026
jsternberg
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3822