-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli changes to expose dry-run mode for prune commands #1239
base: master
Are you sure you want to change the base?
Conversation
Please sign your commits following these rules: $ git clone -b "30623-dry-run-prune" [email protected]:adhulipa/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354236464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
dfa6dbf
to
3ea0211
Compare
Testing on my box is taking a while. And each time I discover a new |
Codecov Report
@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
+ Coverage 56.72% 56.73% +<.01%
==========================================
Files 310 310
Lines 21800 21827 +27
==========================================
+ Hits 12367 12383 +16
- Misses 8518 8529 +11
Partials 915 915 |
@silvin-lubecki @vdemeester |
4c295e5
to
bb1bdc5
Compare
Use: `docker system prune --dry-run` `docker network prune --dry-run` `docker container prune --dry-run` `docker image prune --dry-run` `docker volume prune --dry-run` Signed-off-by: Aditya Dhulipala <[email protected]>
bb1bdc5
to
ec5f4ef
Compare
This is a WIP commit based off of the main moby engine issue
I'd still have to add some more unit tests, I spent a bulk of my time rebasing over the past changes (phew!)