Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli changes to expose dry-run mode for prune commands #1239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adhulipa
Copy link

This is a WIP commit based off of the main moby engine issue

I'd still have to add some more unit tests, I spent a bulk of my time rebasing over the past changes (phew!)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "30623-dry-run-prune" [email protected]:adhulipa/cli.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354236464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@adhulipa
Copy link
Author

Testing on my box is taking a while. And each time I discover a new ridiculous mistake on my part. Close to completion though.

@codecov-io
Copy link

codecov-io commented Nov 10, 2018

Codecov Report

Merging #1239 into master will increase coverage by <.01%.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   56.72%   56.73%   +<.01%     
==========================================
  Files         310      310              
  Lines       21800    21827      +27     
==========================================
+ Hits        12367    12383      +16     
- Misses       8518     8529      +11     
  Partials      915      915

@adhulipa
Copy link
Author

@silvin-lubecki @vdemeester
I was wondering if you could take a quick glance at my CR?

@adhulipa adhulipa force-pushed the 30623-dry-run-prune branch 2 times, most recently from 4c295e5 to bb1bdc5 Compare April 11, 2019 05:59
Use:
    `docker system prune --dry-run`
    `docker network prune --dry-run`
    `docker container prune --dry-run`
    `docker image prune --dry-run`
    `docker volume prune --dry-run`

Signed-off-by: Aditya Dhulipala <[email protected]>
@adhulipa adhulipa force-pushed the 30623-dry-run-prune branch from bb1bdc5 to ec5f4ef Compare June 20, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants