Added confirmation when removing volumes #1437 #1465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Confirmation is now required for deleting a volume with
docker volume rm
. (#1437)It will ask a confirmation for each volumes.
- How I did it
Simply added a condition in
/cli/command/volume/remove.go
.- How to verify it
Create some volumes with
docker volume create [name]
(eg.docker volume create dog-volume
,docker volume create cat-volume
,docker volume create rabbit-volume
) then delete them withdocker volume rm
(docker volume rm cat-volume dog-volume
).- A picture of a cute animal
