#692 Updates builder.md to point out the fact that single-quotes will not unpack vars, resolves #692 #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "692-label-single-quotes" [email protected]:TheHipbot/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
TheHipbot
force-pushed
the
692-label-single-quotes
branch
from
059fc81 to
d447695
Compare
TheHipbot
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
==========================================
- Coverage 55.14% 54.19% -0.96%
==========================================
Files 289 289
Lines 19371 19377 +6
==========================================
- Hits 10683 10502 -181
- Misses 7996 8199 +203
+ Partials 692 676 -16 |
|
resolves #692 |
thaJeztah
reviewed
Oct 25, 2018
docs/reference/builder.md
Outdated
| @@ -738,6 +738,11 @@ To view an image's labels, use the `docker inspect` command. | |||
| "other": "value3" | |||
| }, | |||
|
|
|||
| > **Note**: | |||
| > When providing a `LABEL` in a Dockerfile, be sure to use double quotes and not single quotes. Particularly when you are | |||
| > using string interpolation (e.g. `LABEL example="$env_var") single quotes will take the string as is without | |||
There was a problem hiding this comment.
wondering though; why put quotes there in the first place? ie; this would work as well;
LABEL example=$ENV_VAR
There was a problem hiding this comment.
fine by me, I updated the PR
…unpack variables Signed-off-by: Jeremy Chambers <[email protected]>
TheHipbot
force-pushed
the
692-label-single-quotes
branch
from
d447695 to
0255d84
Compare
thaJeztah
added
kind/docs
status/3-docs-review
area/builder
and removed
status/0-triage
labels
crazy-max
added a commit
to crazy-max/buildkit
that referenced
this pull request
Oct 31, 2022
carry docker/cli#1467 Signed-off-by: CrazyMax <[email protected]>
|
Carried by moby/buildkit#3241, can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unpack variables
- What I did
Updated the docs in builder.md
- How I did it
Edited the md files
- How to verify it
Wait for feedback
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)