-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image/tree: Chips to represent "in use" #5744
Conversation
0e3e9d2
to
dc2b0ce
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (2.84%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5744 +/- ##
==========================================
- Coverage 59.42% 59.26% -0.17%
==========================================
Files 347 353 +6
Lines 29402 29618 +216
==========================================
+ Hits 17472 17552 +80
- Misses 10958 11086 +128
- Partials 972 980 +8 |
dc2b0ce
to
d05a98b
Compare
c7934c1
to
860acf0
Compare
I really like this! I wonder if |
860acf0
to
2320a7e
Compare
2320a7e
to
670150b
Compare
Changed to Info, WDYT? |
I'll echo what I said in the maintainer meeting yesterday: I don't mind the presentation, I like the idea of compressing the visible data where we can, but I do wonder whether we have enough users that care (or even should care) about whether or not an image has an attestation to display it by default. I'm all for the data being available on the CLI for custom "In Use", however, is something that I think is relevant to every user 👍 |
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
670150b
to
c950d48
Compare
Removed attested |
Replace
In Use
column withExtra
(needs a better name though), that uses "chips" / "badges" to show whether the image is in use.