Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/tree: Chips to represent "in use" #5744

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Jan 14, 2025

Replace In Use column with Extra (needs a better name though), that uses "chips" / "badges" to show whether the image is in use.

image
`docker images --tree` now shows metadata badges

@vvoland vvoland added area/ux containerd-integration Issues and PRs related to containerd integration labels Jan 14, 2025
@vvoland vvoland self-assigned this Jan 14, 2025
@vvoland vvoland force-pushed the image-tree-chips branch 2 times, most recently from 0e3e9d2 to dc2b0ce Compare January 14, 2025 12:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 2.84360% with 205 lines in your changes missing coverage. Please review.

Project coverage is 59.26%. Comparing base (17c5fe6) to head (c950d48).
Report is 90 commits behind head on master.

❌ Your patch status has failed because the patch coverage (2.84%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5744      +/-   ##
==========================================
- Coverage   59.42%   59.26%   -0.17%     
==========================================
  Files         347      353       +6     
  Lines       29402    29618     +216     
==========================================
+ Hits        17472    17552      +80     
- Misses      10958    11086     +128     
- Partials      972      980       +8     

@vvoland vvoland marked this pull request as ready for review January 21, 2025 16:42
@vvoland vvoland force-pushed the image-tree-chips branch 4 times, most recently from c7934c1 to 860acf0 Compare January 22, 2025 15:24
@laurazard
Copy link
Collaborator

I really like this! I wonder if INFO would be better for that header, or maybe no header at all?

@vvoland vvoland added this to the 28.0.0 milestone Jan 23, 2025
@vvoland
Copy link
Collaborator Author

vvoland commented Jan 23, 2025

Changed to Info, WDYT?

@tianon
Copy link
Contributor

tianon commented Jan 31, 2025

I'll echo what I said in the maintainer meeting yesterday: I don't mind the presentation, I like the idea of compressing the visible data where we can, but I do wonder whether we have enough users that care (or even should care) about whether or not an image has an attestation to display it by default. I'm all for the data being available on the CLI for custom --format strings so that tiny subset of users who do care about this data can add it, but adding it by default seems like a mistake (especially when it's such a lossy bit of data all by itself -- what kind of attestation? is this an SBOM? is this a provenance doc? is it a signature?).

"In Use", however, is something that I think is relevant to every user 👍

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland changed the title image/tree: Chips to represent "in use"/"attested" image/tree: Chips to represent "in use" Feb 3, 2025
@vvoland
Copy link
Collaborator Author

vvoland commented Feb 3, 2025

Removed attested

@vvoland vvoland requested a review from thaJeztah February 3, 2025 17:25
@vvoland vvoland merged commit 5b90e0e into docker:master Feb 4, 2025
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux containerd-integration Issues and PRs related to containerd integration kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants