Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image mount options #5755

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

LaurentGoderre
Copy link
Member

@LaurentGoderre LaurentGoderre commented Jan 15, 2025

- What I did

Add support for image mount options. Supports moby/moby#48798

- How I did it

- How to verify it

- Description for the changelog

Add `--mount type=image,image-subpath=[subpath],...` option to mount a specific path from the image.

- A picture of a cute animal (not mandatory but encouraged)

@LaurentGoderre LaurentGoderre force-pushed the image-mount-subpath branch 3 times, most recently from 5e1ea8d to 1baccee Compare February 5, 2025 19:48
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 14.58333% with 41 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (1e3e1bd) to head (04b1b4e).
Report is 8 commits behind head on master.

❌ Your patch status has failed because the patch coverage (14.58%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
- Coverage   59.25%   59.18%   -0.08%     
==========================================
  Files         352      352              
  Lines       29496    29544      +48     
==========================================
+ Hits        17479    17486       +7     
- Misses      11042    11078      +36     
- Partials      975      980       +5     

@LaurentGoderre LaurentGoderre marked this pull request as ready for review February 5, 2025 19:53
@vvoland vvoland added this to the 28.0.0 milestone Feb 6, 2025
Signed-off-by: Laurent Goderre <[email protected]>
Copy link
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit c9e7dae into docker:master Feb 13, 2025
104 of 107 checks passed
@LaurentGoderre LaurentGoderre deleted the image-mount-subpath branch February 13, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants