-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Suggestion to add information about environment #10095
Conversation
I'm concerned this change will introduce more confusion than clarity. Running |
@laurazard that's true, "preserved" is the right word here 👍 Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10095 +/- ##
===========================================
- Coverage 76.98% 19.55% -57.44%
===========================================
Files 2 104 +102
Lines 252 9104 +8852
===========================================
+ Hits 194 1780 +1586
- Misses 51 7137 +7086
- Partials 7 187 +180 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Benjamin Balder Bach <[email protected]>
Co-authored-by: Laura Brehm <[email protected]> Signed-off-by: Benjamin Balder Bach <[email protected]>
haha auto-merge vs. stale bot |
I think by using GitHub's interface, there's something unexpected with the commit data. Please feel free to use this improvement as you please. |
Signed-off-by: Benjamin Balder Bach [email protected]
What I did
I wondered about what happens to a container's environment when you launch commands via
exec
. Is it preserved or do I have to re-do it.Turns out for me (Compose v2) it's nicely preserved.
Added a little general tip for debugging the environment on a running container.