Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker support for s390x #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update docker support for s390x #466

wants to merge 1 commit into from

Conversation

prabhav-thali
Copy link
Contributor

@prabhav-thali prabhav-thali commented Jan 13, 2025 •
edited
Loading

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

vvoland
vvoland reviewed Jan 23, 2025
View reviewed changes
install.sh Outdated
Comment on lines 654 to 655
sles)
if [ "$(uname -m)" != "s390x" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also print some message with an explanation?

Is it okay to drop support for installing versions that were already released for SLES?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to drop support for installing versions that were already released for SLES?

Yes we can drop support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still print an error here saying that SLES packages are no longer supported?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this PR!

Curious; is the plan to drop immediately, or with the next major release (docker v28)? Wondering if that would be an option, so that it can be more clearly communicated that "starting with v28, SLES on s390x is no longer supported" (or something along those lines).

Could we still print an error here saying that SLES packages are no longer supported?

Yeah, probably could use a message added here;

docker-install/install.sh

Lines 469 to 492 in 24f7a31

# Print deprecation warnings for distro versions that recently reached EOL,
# but may still be commonly used (especially LTS versions).
case "$lsb_dist.$dist_version" in
centos.8|centos.7|rhel.7)
deprecation_notice "$lsb_dist" "$dist_version"
;;
debian.buster|debian.stretch|debian.jessie)
deprecation_notice "$lsb_dist" "$dist_version"
;;
raspbian.buster|raspbian.stretch|raspbian.jessie)
deprecation_notice "$lsb_dist" "$dist_version"
;;
ubuntu.bionic|ubuntu.xenial|ubuntu.trusty)
deprecation_notice "$lsb_dist" "$dist_version"
;;
ubuntu.mantic|ubuntu.lunar|ubuntu.kinetic|ubuntu.impish|ubuntu.hirsute|ubuntu.groovy|ubuntu.eoan|ubuntu.disco|ubuntu.cosmic)
deprecation_notice "$lsb_dist" "$dist_version"
;;
fedora.*)
if [ "$dist_version" -lt 40 ]; then
deprecation_notice "$lsb_dist" "$dist_version"
fi
;;
esac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We plan to drop support immediately. When the installation is tried on SLES and RHEL (for s390x), we can add a note rather than a deprecation notice. The note will mention "Effective v27.5, please consult SLES distro statement for s390x support."

@prabhav-thali prabhav-thali force-pushed the drop-distros branch 3 times, most recently from fccc405 to 8e97651 Compare February 18, 2025 13:06
vvoland
vvoland reviewed Feb 18, 2025
View reviewed changes
install.sh
)
echo_docker_as_nonroot
exit 0
echo "Effective v27.5, please consult SLES distro statement for s390x support."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still allow to install versions prior to v27.5?
Currently it will error out even if the script is called with VERSION=v27.4.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we don't want to allow users to install versions before v27.5

@prabhav-thali
drop SLES & RHEL support
4cccc20 
Signed-off-by: Prabhav Thali <[email protected]>
@docker docker deleted a comment from TAMERALKHATE3B Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@vvoland vvoland vvoland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhav-thali @thaJeztah @vvoland