Add mac_address to connect_container_to_network #1756
Conversation
hongbin
force-pushed
the
connect-with-mac
branch
from
20294e3 to
69c8b93
Compare
|
Thanks! Do you mind adding the appropriate version check? |
Signed-off-by: Hongbin Lu <[email protected]>
hongbin
force-pushed
the
connect-with-mac
branch
from
69c8b93 to
7e20a90
Compare
|
@shin- Done |
|
I tried adding a test for this, but I don't think this is supported by the engine yet as no matter what I do, I'm not able to set a different MAC address for the network. This is reinforced by the fact that there is currently no CLI option to achieve this: moby/moby#33715 Until this actually works with the Docker Engine, I think we probably shouldn't merge this PR. |
This patch changed the workflow to configure the network in docker. The old workflow is as following: * Create container with default network_mode (which connected to 'bridge' network by default) * Disconnect from 'bridge' network * Connect to each requested neutron network The problem is that docker-py doesn't support connect with specified MAC address [1]. This caused problems on SR-IOV support, which required to set the MAC address. Therefore, we need to change to a new workflow: * Create container with the first requested neutron network * Connect to the rest of the neutron networks [1] docker/docker-py#1756 Change-Id: Ib26fc3458c95c3b3d5df9566acdb0a2d28d1eb30
|
Please sign your commits following these rules: $ git clone -b "connect-with-mac" [email protected]:hongbin/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354570992
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Hongbin Lu <[email protected]>
hongbin
force-pushed
the
connect-with-mac
branch
from
40c4dee to
92b33ea
Compare
|
@shin- when you said "I'm not able to set a different MAC address for the network", could you provide the exact reproducing steps? I will follow up with that. |
No description provided.