-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing the revert suggested by @shin- ages ago #2300
base: main
Are you sure you want to change the base?
Conversation
Please sign your commits following these rules: $ git clone -b "6018" [email protected]:abrugh/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
17b6e0b
to
f3b2c32
Compare
5ec47c1
to
1a98e59
Compare
This PR is not passing due to an already solved problem. |
Signed-off-by: Alexander Brugh <[email protected]>
Rebased, still failing AttachContainerTest::test_attach_stream_and_cancel but only 2 out of 4 times.... |
Looks like it's failing pretty consistently on Python 2.7 (if you look at the test matrix here). To me that suggests that that condition does something helpful, and the fix is less trivial than it appears. |
Fixes the issue described, tested and reproduced in docker/compose#6018