Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement summary bars for feature attributes #21667

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sarahsanders-docker
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker commented Dec 18, 2024

Description

  • Create summary-bar.html shortcode
  • Inline styling

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Preview: https://deploy-preview-21667--docsdocker.netlify.app/security/for-admins/hardened-desktop/settings-management/configure-admin-console/

@sarahsanders-docker sarahsanders-docker added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Dec 18, 2024
@github-actions github-actions bot added area/security hugo Updates related to hugo labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c7ddeca
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/678ac3fc323e04000851f0a5
😎 Deploy Preview https://deploy-preview-21667--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker
Copy link
Contributor

aevesdocker commented Dec 19, 2024

This is looking really great @sarahsanders-docker. I have a few thinking-out-loud comments:

  • The blue banner is quite dominating. I wonder if it needs to blend in a tad more. Is there a lighter colour or perhaps, like the examples I added to the Notion page, we use lines to separate it 🤔
  • Is it clear that 'Business' means Business subscription? Is there a way we could use a hover-over tooltip that spells it out more fully? Or am I overthinking it
  • The order we display the info may need changing. "Available for: EA" for example, doesn't make sense. Perhaps we put life cycle info first, then 'Available for:....etc'?

@sarahsanders-docker sarahsanders-docker changed the title [WIP] summary bars implement summary bars for feature attributes Jan 10, 2025
@sarahsanders-docker sarahsanders-docker marked this pull request as ready for review January 10, 2025 19:44
@sarahsanders-docker sarahsanders-docker requested a review from a team January 10, 2025 19:44
@aevesdocker
Copy link
Contributor

aevesdocker commented Jan 13, 2025

This is looking great! Liking this next iteration.
Is there a reason we don't have an option to show what persona this is for? Or having a specific option to show that the content is for an Admin?

@sarahsanders-docker
Copy link
Contributor Author

This is looking great! Liking this next iteration. Is there a reason we don't have an option to show what persona this is for? Or having a specific option to show that the content is for an Admin?

@aevesdocker In my notes from the Docs huddle feedback, we said it didn't make sense to only reference persona sometimes. If we are tagging docs with an Admin persona, would we have to then tag docs with a Developer persona? Or create additional personas? Happy to bring the discussion back these week in huddle if we should talk through it again

@aevesdocker
Copy link
Contributor

I think it's worth having the option to add an item to say that specific pages are targeted at Administrators. And I don't think we'd have to tag other pages with the developer or other personas, we'd just leave that item out. It doesn't need to be an all or nothing thing.
We have instances where there are Docker Business features but they're for admins to set up and I'd personally think users would find it useful to know if it's relevant to them or not

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Jan 14, 2025
@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Jan 14, 2025
@github-actions github-actions bot added area/cli Relates to the CLI client area/scout Relates to Docker Scout labels Jan 15, 2025
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look, left some suggestions on how I would approach this. Note: I haven't actually run the code I wrote here so there might be an error somewhere, but I hope it captures the idea. Let me know what you think or if you need more guidance.

layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
data/summary.yaml Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Show resolved Hide resolved
layouts/shortcodes/summary-bar.html Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/extensions Relates to Docker Extensions area/admin Relates to Docker Admin area/copilot labels Jan 15, 2025
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/compose Relates to docker-compose.yml spec or docker-compose binary area/storage Relates to storage, volumes labels Jan 16, 2025
@github-actions github-actions bot added the area/hub Issue affects Docker Hub label Jan 17, 2025
@sarahsanders-docker sarahsanders-docker force-pushed the summary-bar branch 3 times, most recently from 9185089 to fc93712 Compare January 17, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin Relates to Docker Admin area/build Relates to Dockerfiles or docker build command area/cli Relates to the CLI client area/compose Relates to docker-compose.yml spec or docker-compose binary area/copilot area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/extensions Relates to Docker Extensions area/hub Issue affects Docker Hub area/scout Relates to Docker Scout area/security area/storage Relates to storage, volumes hugo Updates related to hugo status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants