Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker support for s390x #21798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prabhav-thali
Copy link
Contributor

@prabhav-thali prabhav-thali commented Jan 13, 2025

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/678518b3997588045ff35377
😎 Deploy Preview https://deploy-preview-21798--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/compose Relates to docker-compose.yml spec or docker-compose binary area/install Relates to installing a product area/security area/storage Relates to storage, volumes labels Jan 13, 2025
@dvdksn dvdksn closed this Jan 13, 2025
@prabhav-thali
Copy link
Contributor Author

Hi @dvdksn, Why was this PR closed?

@dvdksn dvdksn reopened this Jan 13, 2025
@dvdksn
Copy link
Collaborator

dvdksn commented Jan 13, 2025

@prabhav-thali sorry, my mistake

@prabhav-thali
Copy link
Contributor Author

@dvdksn No issues! Could you please guide me on failed PR checks?

@dvdksn
Copy link
Collaborator

dvdksn commented Jan 13, 2025

Taking a look 👀

@dvdksn
Copy link
Collaborator

dvdksn commented Jan 13, 2025

OK, deploy preview is live now. Something failed on Netlify's side.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third bullet in the prerequisites below this still talks about SLES. I guess we can remove the last sentence.

- `btrfs` requires a dedicated block storage device such as a physical disk. This
block device must be formatted for Btrfs and mounted into `/var/lib/docker/`.
The configuration instructions below walk you through this procedure. By
default, the SLES `/` filesystem is formatted with Btrfs, so for SLES, you do
not need to use a separate block device, but you can choose to do so for
performance reasons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was present even before the doc was updated for s390x support. Hence, kept the same. But yes, we can remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary area/engine Issue affects Docker engine/daemon area/install Relates to installing a product area/security area/storage Relates to storage, volumes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants