Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2489 #22262

Merged
merged 7 commits into from
Mar 17, 2025
Merged

ENGDOCS-2489 #22262

merged 7 commits into from
Mar 17, 2025

Conversation

aevesdocker
Copy link
Contributor

Description

Adds compose-spec/compose-spec#572
Adds compose-spec/compose-spec#576
Adds compose-spec/compose-spec#579

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Mar 17, 2025
Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit c6584fa
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67d836f20991ad000821fdac
😎 Deploy Preview https://deploy-preview-22262--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested a review from a team March 17, 2025 12:05
@@ -1321,6 +1321,28 @@ services:
```
For more information about the `networks` top-level element, see [Networks](networks.md).

### implicit default network
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### implicit default network
### `implicit default network`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my b. should be normal sentence case. have fixed!

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit about backticks for a heading

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aevesdocker aevesdocker merged commit 4b21fc2 into docker:main Mar 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants