Skip to content

25174 25165#25179

Merged
aevesdocker merged 3 commits into
docker:mainfrom
aevesdocker:25174-25165
May 27, 2026
Merged

25174 25165#25179
aevesdocker merged 3 commits into
docker:mainfrom
aevesdocker:25174-25165

Conversation

@aevesdocker

Copy link
Copy Markdown
Contributor

Description

Closes #25165
Addresses #25174

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions Bot added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions labels May 27, 2026
@netlify

netlify Bot commented May 27, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1a76c37
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a16f811072286000868bc0f
😎 Deploy Preview https://deploy-preview-25179--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aevesdocker aevesdocker marked this pull request as ready for review May 27, 2026 13:03

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR makes three clean, targeted improvements:

  1. WSL page — adds a helpful clarification that when the WSL 2 engine option is already on by default, the setting is not visible in the UI. Accurate and useful.
  2. Extensions architecture page — fixes two misleading link labels that said "ui metadata section" and now correctly read `vm` metadata section and host metadata section respectively. These are straightforward accuracy fixes.

No AI-isms, no missing redirects, no vendored file edits, no style-guide violations detected. One minor trailing space flagged inline.

Comment thread content/manuals/desktop/features/wsl/_index.md
@aevesdocker aevesdocker requested a review from a team May 27, 2026 13:03
@aevesdocker aevesdocker added the status/review Pull requests that are ready for review label May 27, 2026
Comment thread content/manuals/extensions/extensions-sdk/architecture/_index.md Outdated
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@aevesdocker aevesdocker requested a review from dvdksn May 27, 2026 13:56
@aevesdocker aevesdocker enabled auto-merge (squash) May 27, 2026 13:56
@aevesdocker aevesdocker merged commit 810e553 into docker:main May 27, 2026
16 checks passed

@docker-agent docker-agent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This is a small, clean documentation PR with two focused improvements:

  • WSL page: Adds useful clarification that the WSL 2 engine setting is hidden when WSL 2 is already supported — this addresses user confusion when the setting doesn't appear in the UI.
  • Extensions SDK architecture page: Fixes two imprecise link texts (ui metadata section) to accurately reflect the linked section names (vm metadata section, host metadata section) using inline code formatting — a good precision improvement.

No vendored files, no missing redirects, no AI-isms, no structural concerns. One minor trailing-space nit on the WSL change.

5. From the **General** tab, select **Use WSL 2 based engine**.

If you have installed Docker Desktop on a system that supports WSL 2, this option is turned on by default.
If you have installed Docker Desktop on a system that supports WSL 2, this option is turned on by default and the setting is not visible.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Trailing whitespace at end of added line

The added sentence ends with a trailing space before the newline: ...not visible. (note the space after the period). While most Markdown renderers ignore this, it's a minor formatting defect worth tidying up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs-scanner] Incorrect link text in metadata section references

4 participants