[WIP]: Add queue write error channel support #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Vazquez <[email protected]>
|
@coderbirju, wondering if you could take a look at this wip proof of concept. |
austinvazquez
commented
Oct 23, 2024
| @@ -63,26 +89,21 @@ func (eq *Queue) Close() error { | |||
| } | |||
|
|
|||
| // run is the main goroutine to flush events to the target sink. | |||
| func (eq *Queue) run() { | |||
| func (eq *Queue) run(ctx context.Context) { | |||
There was a problem hiding this comment.
Need to hook in context into the goroutine's lifecycle here. Will require a major refactor of this implementation though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#36
Description
This change adds a mechanism for returning write errors to users via a read-only channel. This deprecates the previously provided
NewQueueevents package.