Ensure Dockerfile has Linux-only npm packages in lock file. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package-lock.json file committed to the repository may lack Linux-only packages that wouldn't be installed by `npm install` on (say) macOS. This currently blocks `docker build .` from succeeding. The only robust solution to this is to allow lock file updatings during the Docker build. Signed-off-by: Jacob Howard <[email protected]>
lucadruda
approved these changes
Oct 31, 2025
Collaborator
|
@xenoscopic thanks. The workflow is now disable as we rely on the Docker MCP toolkit CI now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Dockerfileto regenerate thepackage-lock.jsonfile during builds to ensure that Linux-only packages are included.docker build .currently fails otherwise.Tool Details
n/a
Motivation and Context
The package-lock.json file committed to the repository may lack Linux-only packages that wouldn't be installed by
npm installon (say) macOS. This currently blocksdocker build .from succeeding. The only robust solution to this is to allow lock file updatings during the Docker build.How Has This Been Tested?
Tested manually.
Breaking Changes
n/a
Types of changes
Checklist
Additional context
@lucadruda I think this should have been caught by https://github.com/docker/hub-mcp/actions/workflows/release.yml, but it looks like that workflow was disabled.