Conversation
slimslenderslacks
requested changes
Sep 10, 2025
Collaborator
slimslenderslacks
left a comment
slimslenderslacks
left a comment
There was a problem hiding this comment.
This looks totally right to me. Is there anyway you can add a test to go along with other telemetry tests?
Contributor
Author
|
I was looking for the tests when I wrote this but couldn't find them 🤦♂️ I see them now though! Will do that. |
Contributor
Author
|
Done |
saucow
approved these changes
Sep 11, 2025
null-runner
pushed a commit
to null-runner/mcp-gateway
that referenced
this pull request
Dec 6, 2025
* Add telemetry for initialize. * Add intitialize span test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added telemetry for initialize when a client connects to the gateway. It includes the client and version.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did