Merged
Conversation
saucow
approved these changes
Sep 16, 2025
slimslenderslacks
approved these changes
Sep 16, 2025
| attribute.String("mcp.server.name", serverConfig.Name), | ||
| attribute.String("mcp.server.type", serverType), | ||
| attribute.String("mcp.tool.name", req.Params.Name), | ||
| attribute.String("mcp.client.name", req.Session.InitializeParams().ClientInfo.Name), |
Collaborator
There was a problem hiding this comment.
I think Name is safest here. We do have Title and Version as well and are meant to be the human-readable ones for displays in UIs. Should we start logging these parameters when clients connect to the gateway so we're more accustomed to how these different clients identify themselves? I think it'd be worth logging one client connected message and showing the name, title and version of the client.
I still think the Name is the right thing to add to the event.
Contributor
Author
There was a problem hiding this comment.
Yes I think that makes sense. Created an issue: #141
null-runner
pushed a commit
to null-runner/mcp-gateway
that referenced
this pull request
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added the client name (e.g.
claude-ai) to telemetry metrics under the attributemcp.client.name.Metrics Affected
mcp.tool.callsmcp.tool.durationmcp.list.toolsmcp.prompt.getsmcp.prompt.durationmcp.list.promptsmcp.list.resourcesmcp.resource.readsmcp.resource.durationmcp.list.resource_templatesmcp.resource_template.readsmcp.resource_template.duration