Skip to content

Add Zed client configuration#143

Merged
slimslenderslacks merged 5 commits intodocker:mainfrom
bobbyhouse:add-zed
Sep 17, 2025
Merged

Add Zed client configuration#143
slimslenderslacks merged 5 commits intodocker:mainfrom
bobbyhouse:add-zed

Conversation

@bobbyhouse
Copy link
Copy Markdown
Contributor

@bobbyhouse bobbyhouse commented Sep 16, 2025

What I did

Added support for the Zed editor to docker mcp client commands:

  • docker mcp client connect zed -g
  • docker mcp client disconnect zed -g
  • docker mcp client ls -g

The zed configuration file at $HOME/.config/zed/settings.json contains comments (example in test data cmd/docker-mcp/client/testdata/add_del/zed-append/original.jsonc).

This would cause errors when trying to parse the file with json encoder provided by yqlib (NewJSONEncoder). This PR adds tailscale/hujson to do the initial parsing and then turn into valid JSON before passing the data onto the JSONEncoder provided by yqlib.

Additionally, did some reformatting of config.yml

Note

This process is destructive and comments in the settings file are not preserved. You can see what the expected output format is in the test data (cmd/docker-mcp/client/testdata/add_del/zed-append/after-add.json)

Another Note

The image in Docker Desktop is broken for Zed. The pattern is to host the image from this repository (e.g. Goose image). An image from the resources section of Zed's website has been added for "Zed Stable."

Demo

zed-docker-mcp-client.mp4
zed-docker-desktop-mcp-client.mp4

Related issue
Addresses #58

(not mandatory) A picture of a cute animal, if possible in relation to what you did

baby-zebra

Add package for JSON parsing that supports comments used in Zed's
`$HOME/.config/zed/settings.json`. Without JSON parsing that understands
comments yq fails to read the settings.json file.
https://github.com/tailscale/hujson
Add preprocessing to handle comments in JSON using tailscale/hujson.
Add client configuration for Zed https://zed.dev/

Addresses docker#58
@bobbyhouse bobbyhouse requested a review from a team as a code owner September 16, 2025 18:29
@slimslenderslacks slimslenderslacks merged commit e733841 into docker:main Sep 17, 2025
5 checks passed
null-runner pushed a commit to null-runner/mcp-gateway that referenced this pull request Dec 6, 2025
* Add tailscale/hujson for JSON parsing

Add package for JSON parsing that supports comments used in Zed's
`$HOME/.config/zed/settings.json`. Without JSON parsing that understands
comments yq fails to read the settings.json file.
https://github.com/tailscale/hujson

* style: Fix indentation

* Add preprocessing of input

Add preprocessing to handle comments in JSON using tailscale/hujson.

* feat: Add Zed client

Add client configuration for Zed https://zed.dev/

Addresses docker#58

* chore: update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants