fix: include poci servers in catalog-next legacy catalog import#446
Closed
fix: include poci servers in catalog-next legacy catalog import#446
Conversation
When converting a legacy catalog to catalog-next format, `createCatalogFromLegacyCatalog` only handled `server` and `remote` types, silently dropping `poci` servers (e.g. curl, ffmpeg, docker). This caused poci servers to disappear from the Docker Desktop catalog when the MCPWorkingSets feature flag was enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPWorkingSetsfeature flag is enabled, Docker Desktop uses thecatalog-nextAPI path which callscreateCatalogFromLegacyCatalogto convert the legacy Docker MCP catalog. This function only handledserver(with image) andremotetypes, silently droppingpociservers likecurl,ffmpeg, anddocker.pocias a first-classServerTypethroughout the catalog-next pipeline: workingset types, catalog-next server struct, DB schema migration, and the legacy catalog import function.MCPWorkingSetsis enabled.Changes
pkg/catalog_next/create.goAdded
else if server.Type == "poci"branch increateCatalogFromLegacyCatalog:pkg/workingset/workingset.goServerTypePoci ServerType = "poci"constantServer.Typevalidation to includepociResolveFilefor servers without a top-level imagepkg/catalog_next/catalog.goServer.Typevalidation to acceptpocipkg/db/migrations/007_add_poci_support.up.sqlpocito thecatalog_server.server_typeCHECK constraintTest plan
TestCreateFromLegacyCatalogWithPociServersverifies poci servers survive the legacy→catalog-next round tripcatalog_next,workingset,db, andpolicytests passMCPWorkingSetsflag, verify curl/ffmpeg/docker appear in Docker Desktop catalogHow to verify locally
🤖 Generated with Claude Code