Skip to content

ci(release): update release input to choose release type #247

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:gh-release-type
Aug 22, 2025
Merged

ci(release): update release input to choose release type #247
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:gh-release-type

Conversation

@crazy-max
Copy link
Copy Markdown
Member

No description provided.

@crazy-max crazy-max requested a review from vvoland August 19, 2025 11:26
@crazy-max crazy-max marked this pull request as ready for review August 19, 2025 11:26
@crazy-max crazy-max changed the title ci(release): input to choose GitHub Release type ci(release): update release input to choose release type Aug 20, 2025
@crazy-max crazy-max requested a review from vvoland August 20, 2025 11:41
release:
required: false
type: boolean
type: string
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame that Github doesn't support choice in reusable workflows 🙈

Should we have an additional verify job that would assert that this is has expected values?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed I will check that

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum actually empty is expected for build-* workflows

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still check if its any of "" | "pushonly" | "draft" | "prerelease" | "release"

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit 4c7314a into docker:main Aug 22, 2025
507 checks passed
@crazy-max crazy-max deleted the gh-release-type branch August 22, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants