hack: handle prefixed version formats in gen-ver.sh#291
hack: handle prefixed version formats in gen-ver.sh#291crazy-max merged 1 commit intodocker:mainfrom
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
There was a problem hiding this comment.
Hum I think we need to adapt GIT_TAG as well
packaging/.github/workflows/.build.yml
Lines 211 to 222 in 6fdba44
|
Hmm I think using EDIT: Oh, looks like it won't. packaging/pkg/model/Dockerfile Line 76 in 6fdba44 |
| if [[ "$version" =~ .*/v[0-9] ]]; then | ||
| version="${version##*/}" | ||
| fi | ||
| # docker-v29.0.0 -> v29.0.0 |
There was a problem hiding this comment.
Just curious, this is the future tagging strategy starting moby 29?
There was a problem hiding this comment.
Yes, it's supposed to be a tag that's not going to be picked up by Go as a valid go module (because github.com/moby/moby module has different versioning than Docker Engine)
|
Hmm looks like it's not working right: |
No description provided.