Skip to content

fix(editor): remove stale items after rewrite - #46

Draft
pablopupo wants to merge 1 commit into
docling-project:mainfrom
pablopupo:fix/45-remove-rewritten-items
Draft

fix(editor): remove stale items after rewrite#46
pablopupo wants to merge 1 commit into
docling-project:mainfrom
pablopupo:fix/45-remove-rewritten-items

Conversation

@pablopupo

Copy link
Copy Markdown

Fixes #45.

rewrite_content only replaced refs[0], leaving the other selected items behind. The selected refs are now deduplicated and put in document order before the replacement, and the remaining originals are removed afterward.

Added regression coverage for multiple refs, duplicate refs, and nested items.

Signed-off-by: Pablo Pupo <pablofpupo23@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

DCO Check Passed

Thanks @pablopupo, all your commits are properly signed off. 🎉

@mergify

mergify Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 2 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require two reviewer for test updates 👀 reviews
🟢 Enforce conventional commit

🔴 Require two reviewer for test updates

Waiting for

  • #approved-reviews-by >= 1
This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 1

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: insert_document only removes refs[0]; refs[1..N] left as orphans after rewrite_content

1 participant