Skip to content

Conversation

@vtempest
Copy link
Contributor

@vtempest vtempest commented Jun 7, 2025

Google Docs, Files, PDF URLs, Spreadsheets, Presentations to EXPORT URL

@mergify
Copy link

mergify bot commented Jun 7, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@vtempest vtempest changed the title # Google Docs, Files, PDF URLs, Spreadsheets, Presentations to EXPORT URL feat: Google Docs, Files, PDF URLs, Spreadsheets, Presentations to EXPORT URL Jun 7, 2025
@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/utils/file.py 23.07% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dolfim-ibm
Copy link
Contributor

@vtempest it seems your commits are not yet signed-off. Can you please follow the steps in https://github.com/docling-project/docling-core/pull/320/checks?check_run_id=43652326093?

@vtempest
Copy link
Contributor Author

vtempest commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/utils/file.py 23.07% 10 Missing ⚠️
📢 Thoughts on this report? Let us know!

Will someone write unit tests for codecov? Or where to add them?

@vtempest
Copy link
Contributor Author

vtempest commented Jun 8, 2025

should this be in a separate file like called url-to-doc-adapters.py

which should handle google docs, dropbox, scribr etc

vtempest and others added 8 commits June 8, 2025 13:47
* feat(BoundingBox): add methods for overlap and union calculations

Signed-off-by: samiullahchattha <[email protected]>

* format files

Signed-off-by: samiullahchattha <[email protected]>

---------

Signed-off-by: samiullahchattha <[email protected]>
Co-authored-by: samiullahchattha <[email protected]>
Signed-off-by: vtempest <[email protected]>
Adding support for section_header levels in doctags deserialization

Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: vtempest <[email protected]>
fix: typer version with new click

Signed-off-by: Michele Dolfi <[email protected]>
Signed-off-by: vtempest <[email protected]>
* feat: add table annotations

Signed-off-by: Panos Vagenas <[email protected]>

* refactor annotation types

Signed-off-by: Panos Vagenas <[email protected]>

* expand to HTML

Signed-off-by: Panos Vagenas <[email protected]>

* introduce annotation serializer

Signed-off-by: Panos Vagenas <[email protected]>

* Update dummy_doc.yaml

Signed-off-by: Panos Vagenas <[email protected]>

---------

Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: vtempest <[email protected]>
* feat: add subscript & superscript formatting

Signed-off-by: Panos Vagenas <[email protected]>

* switch to enum

Signed-off-by: Panos Vagenas <[email protected]>

---------

Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: vtempest <[email protected]>
@dolfim-ibm
Copy link
Contributor

Will someone write unit tests for codecov? Or where to add them?

This is checking the overall tests in the repo. But in this case I don't really know if we can easily make tests. Maybe with some public readable links.

@vtempest
Copy link
Contributor Author

will some one handle the coddcov? do i just need to sign the commits

@dolfim-ibm
Copy link
Contributor

will some one handle the coddcov? do i just need to sign the commits

coddcov is not an issue, it is only a warning. but the sign-off is indeed required.

@vtempest
Copy link
Contributor Author

Ok I signed and tried to merge the updated files. Let me know if the merges were correct or I can resubmit PR since it is confusing what went throught

@dolfim-ibm
Copy link
Contributor

this is so weird. now the git history shows some mixed merge.

I'm sorry to ask it, but it could be easier to make a fresh PR where all the commits are signed-off from the beginning.

@github-actions
Copy link
Contributor

DCO Check Passed

Thanks @vtempest, all your commits are properly signed off. 🎉

@vtempest
Copy link
Contributor Author

It needs 2 people to approve the merges to the standard files like pyproject toml
Sorry should I recreate or how to fix?

@vagenas
Copy link
Collaborator

vagenas commented Jun 27, 2025

Closing this one as superseded by #335.

@vagenas vagenas closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants