fix: parameterized disable_numparse for MarkdownTableSerializer#414
Open
lucaselvaggio wants to merge 3 commits intodocling-project:mainfrom
Open
fix: parameterized disable_numparse for MarkdownTableSerializer#414lucaselvaggio wants to merge 3 commits intodocling-project:mainfrom
lucaselvaggio wants to merge 3 commits intodocling-project:mainfrom
Conversation
Contributor
|
❌ DCO Check Failed Hi @lucaselvaggio, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for lucaselvaggio <luca.selvaggio@overcash.it>
I, lucaselvaggio <luca.selvaggio@overcash.it>, hereby add my Signed-off-by to this commit: 393809fa761ea9db6c13959684ccfed0c17a30a0"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, lucaselvaggio <luca.selvaggio@overcash.it>, hereby add my Signed-off-by to this commit: 393809fa761ea9db6c13D959684ccfed0c17a30a0 Signed-off-by: lucaselvaggio <luca.selvaggio@overcash.it>
PeterStaar-IBM
previously approved these changes
Nov 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Luca Selvaggio <102549254+lucaselvaggio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the
disable_table_numparseparameter toMarkdownParams, enabling it to be passed through to theexport_to_markdownfunction.When set to
True, this flag is forwarded to thetabulatefunction viadisable_numparse, preventing automatic numeric parsing.Previously, numeric values containing trailing zeros (e.g. "50.000") were automatically parsed and reformatted (e.g. to "50"), resulting in loss of precision in the Markdown table output. With this change, setting
disable_table_numparse=Truepreserves the original formatting of numeric strings during Markdown export.Issue ref: docling-project/docling#1891
By exposing this parameter, the implementation provides greater flexibility for different usage scenarios where numeric formatting preservation is required.