Skip to content

Conversation

@Vdaleke
Copy link
Contributor

@Vdaleke Vdaleke commented Nov 16, 2025

Adds **kwargs to the export_to_dataframe method and passes them to _get_text for the table cell.

In TripletTableSerializer, the method is called with doc_serializer, which solves the problem of incorrect serialization.

Tests for the case have been added.

Resolves #423

@github-actions
Copy link
Contributor

DCO Check Failed

Hi @Vdaleke, your pull request has failed the Developer Certificate of Origin (DCO) check.

This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format.


🛠 Quick Fix: Add a remediation commit

Run this command:

git commit --allow-empty -s -m "DCO Remediation Commit for Matvei Smirnov <[email protected]>

I, Matvei Smirnov <[email protected]>, hereby add my Signed-off-by to this commit: 535f9eaf8dcdb7a90794d7ba2cebff6a0176a867"
git push

🔧 Advanced: Sign off each commit directly

For the latest commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/main
git push --force-with-lease

More info: DCO check report

@dosubot
Copy link

dosubot bot commented Nov 16, 2025

Related Documentation

Checked 3 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@mergify
Copy link

mergify bot commented Nov 16, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@Vdaleke Vdaleke closed this Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TripletTableSerializer always serializes rich cells in markdown

1 participant