Skip to content

Conversation

@nassarofficial
Copy link
Contributor

Summary
Ensure pic_title is initialized before either image/non-image branches run in load_from_doctags.
Default the title to "other" and override it with the detected chart_type when available so chart metadata always has a valid title.
Prevents UnboundLocalError when chart data is parsed without an image binary.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

DCO Check Passed

Thanks @nassarofficial, all your commits are properly signed off. 🎉

@dosubot
Copy link

dosubot bot commented Nov 17, 2025

Related Documentation

Checked 3 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@mergify
Copy link

mergify bot commented Nov 17, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Enforce conventional commit

This rule is failing.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

I, Ahmed Nassar <[email protected]>, hereby add my Signed-off-by to this commit: da99c63

Signed-off-by: Ahmed Nassar <[email protected]>
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants