-
Notifications
You must be signed in to change notification settings - Fork 105
feat: convert regions into TableData #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maksym Lysak <[email protected]>
|
✅ DCO Check Passed Thanks @maxmnemonic, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
|
@maxmnemonic A few comments: Direct Replacements
Not Directly Replaceable
Notes
|
Signed-off-by: Maksym Lysak <[email protected]>
13ebdb2 to
ba4d1ea
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vagenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments left inline.
Signed-off-by: Maksym Lysak <[email protected]>
…ngBox.get_intersection_bbox Signed-off-by: Maksym Lysak <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
vagenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: document.py modularization to be addressed in #433
Added capability to load TableData.from_regions
Converts regions (lists of BoundingBox): rows, columns, merged cells into table_data structure,
Adds semantics for regions of row_headers, col_headers, row_section.
Tolerates slight overlaps "wobbly" bounding boxes, in some cases missing bounding boxes, etc.
Includes test_regions_to_table.py - that acts as an example