fix: lazy load transformers in HybridChunker#468
Open
ryyhan wants to merge 1 commit intodocling-project:mainfrom
Open
fix: lazy load transformers in HybridChunker#468ryyhan wants to merge 1 commit intodocling-project:mainfrom
ryyhan wants to merge 1 commit intodocling-project:mainfrom
Conversation
Contributor
|
✅ DCO Check Passed Thanks @ryyhan, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
879c4f9 to
0ed9445
Compare
Signed-off-by: ryyhan <dayel.rehan@gmail.com>
0ed9445 to
addf8bf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Author
|
Hi team, This PR has passed all CI checks and is ready for review. Summary:
@dolfim-ibm Could you please take a look? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #459.
Implements lazy loading for
transformersandsemchunkinHybridChunker. This preventsRuntimeErrorwhen usingdocling-corewith only thechunking-openaiextra (which does not depend ontransformers).Note: This applies the same lazy-loading pattern accepted in
doclingPR #2826(docling-project/docling#2826) (fix: transformers models lazy-loaded).Changes
semchunkimport to_split_using_plain_textmethod.isinstancecheck forPreTrainedTokenizerBasewith a module path string check (tokenizer.__module__) to avoid importingtransformers.Type of change
Checklist