Skip to content

feat(serializer): add MsExcelMarkdownDocSerializer for sheet-name headings#587

Merged
PeterStaar-IBM merged 3 commits into
docling-project:mainfrom
Smeet23:feat/excel-markdown-serializer
Apr 17, 2026
Merged

feat(serializer): add MsExcelMarkdownDocSerializer for sheet-name headings#587
PeterStaar-IBM merged 3 commits into
docling-project:mainfrom
Smeet23:feat/excel-markdown-serializer

Conversation

@Smeet23

@Smeet23 Smeet23 commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds MsExcelMarkdownFallbackSerializer and MsExcelMarkdownDocSerializer to docling_core/transforms/serializer/markdown_excel.py
  • These classes enable rendering GroupLabel.SHEET groups as level-2 Markdown headings (## <sheet_name>) when exporting Excel-sourced DoclingDocuments
  • Requested in feat(xlsx): render sheet names as headings in markdown export docling#3255 — the serializer was originally placed in the docling repo but belongs here per reviewer feedback

Test plan

  • Verify MsExcelMarkdownDocSerializer renders sheet names as ## <name> headings
  • Verify non-SHEET groups are handled by the standard fallback logic
  • Verify the import path from docling_core.transforms.serializer.markdown_excel import MsExcelMarkdownDocSerializer works correctly

🤖 Generated with Claude Code

…dings

Add `MsExcelMarkdownFallbackSerializer` and `MsExcelMarkdownDocSerializer`
to the serializer package so that `GroupLabel.SHEET` groups are rendered as
level-2 Markdown headings when exporting Excel-sourced documents.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mergify

mergify Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

DCO Check Passed

Thanks @Smeet23, all your commits are properly signed off. 🎉

PeterStaar-IBM
PeterStaar-IBM previously approved these changes Apr 14, 2026

@PeterStaar-IBM PeterStaar-IBM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PeterStaar-IBM

Copy link
Copy Markdown
Member

@Smeet23 Please run the DCO and make sure all checks work!

I, Smeet23 <smeetagrawal2003@gmail.com>, hereby add my Signed-off-by to this commit: 2a3808e

Signed-off-by: Smeet23 <smeetagrawal2003@gmail.com>
@Smeet23

Smeet23 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@PeterStaar-IBM Done! Added a DCO remediation commit and all checks are now passing — DCO, dco_advisor, and Mergify merge protections are all green. Thanks for the review and the approval!

@PeterStaar-IBM

Copy link
Copy Markdown
Member

@Smeet23 Please run the uv run pre-commit run --all-files

Signed-off-by: Smeet23 <smeetagrawal2003@gmail.com>
@Smeet23

Smeet23 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi @PeterStaar-IBM — thanks for the earlier LGTM! I've pushed a small follow-up fix: the ruff formatter flagged one line in markdown_excel.py as too long and reformatted it — that was the only reason CI was failing. Everything is now passing (DCO ✅, Mergify ✅). Could you take a quick look at the new commit and re-approve when you get a chance? Happy to address any other concerns. Thanks!

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cling_core/transforms/serializer/markdown_excel.py 0.00% 19 Missing ⚠️

📢 Thoughts on this report? Let us know!

@PeterStaar-IBM PeterStaar-IBM merged commit 9dc882d into docling-project:main Apr 17, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants