Preserve legacy picture description filters#105
Open
drukpa1455 wants to merge 1 commit intodocling-project:mainfrom
Open
Preserve legacy picture description filters#105drukpa1455 wants to merge 1 commit intodocling-project:mainfrom
drukpa1455 wants to merge 1 commit intodocling-project:mainfrom
Conversation
Contributor
|
❌ DCO Check Failed Hi @drukpa1455, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for drk <drukpa1455@gmail.com>
I, drk <drukpa1455@gmail.com>, hereby add my Signed-off-by to this commit: 748c9a98d29ab05d0c6e5da79ff652964f05c429"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legacy picture-description requests can carry a local/API model config, but they currently drop the classification filter fields before those options reach Docling core.
This patch keeps the legacy path honest:
classification_allowclassification_denyclassification_min_confidenceWhy
Docling core already supports classify-first-then-describe filtering.
The gap is in
docling-jobkit:PictureDescriptionLocalandPictureDescriptionApido not define the classification filter fieldsDoclingConverterManagerlater doesmodel_dump()on those legacy modelsPictureDescriptionVlmOptions/PictureDescriptionApiOptionsare builtThe result in
docling-serveis surprising:Changes
PictureDescriptionLocalPictureDescriptionApiTest
uv run --directory /tmp/docling-jobkit-2345 pytest tests/test_options.py -q -k 'legacy_picture_description_filters_reach_pipeline_options or legacy_picture_description_api_filters_reach_pipeline_options'Closes #104.