Support for DoclingServiceClient via protocol - #35
Conversation
|
✅ DCO Check Passed Thanks @phact, all your commits are properly signed off. 🎉 |
Merge Protections🔴 2 of 2 protections blocking · waiting on 👀 reviews and 🙋 you
🔴 Enforce conventional commitWaiting for
This rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
|
I, phact <estevezsebastian@gmail.com>, hereby add my Signed-off-by to this commit: a9c47e3 Signed-off-by: phact <estevezsebastian@gmail.com>
|
@phact this looks very good to me. I'm only wondering (maybe for a future iteration) if we could offer a simple way for langchain users to use the Docling Service Client without installing the whole docling package which includes the heavt AI runtimes. For the Docling MCP project we did it like this https://github.com/docling-project/docling-mcp/blob/main/pyproject.toml#L45-L58 (for inspiration) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adds support for both docling served and managed docling by introducing
DoclingLoader can now take DoclingServiceCient as the
converter