Use CONTAINER_TOOL in all calls, directory in kubectl apply - #62
Merged
Conversation
Signed-off-by: Fabiano Franz <contact@fabianofranz.com>
Contributor
Author
|
@acornett21 @bcrochet ptal |
acornett21
approved these changes
Jul 14, 2025
Collaborator
|
@fabianofranz Thanks for pointing this out. I think the intent was the |
Contributor
Author
Sounds good. Since a kustomization.yaml exists, this will work now already and in future if kustomizations are added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple minor fixes:
CONTAINER_TOOLwheredockerwas hardcoded in the Makefile; andkubectl apply -kmust point to a directory where kustomization.yaml exists.