Skip to content

Use CONTAINER_TOOL in all calls, directory in kubectl apply - #62

Merged
acornett21 merged 1 commit into
docling-project:mainfrom
fabianofranz:minor-fixes
Jul 14, 2025
Merged

Use CONTAINER_TOOL in all calls, directory in kubectl apply#62
acornett21 merged 1 commit into
docling-project:mainfrom
fabianofranz:minor-fixes

Conversation

@fabianofranz

Copy link
Copy Markdown
Contributor

A couple minor fixes:

  • Use CONTAINER_TOOL where docker was hardcoded in the Makefile; and
  • kubectl apply -k must point to a directory where kustomization.yaml exists.

Signed-off-by: Fabiano Franz <contact@fabianofranz.com>
@fabianofranz

Copy link
Copy Markdown
Contributor Author

@acornett21 @bcrochet ptal

@acornett21

Copy link
Copy Markdown
Collaborator

@fabianofranz Thanks for pointing this out. I think the intent was the -f flag, but -k makes sense in case in the future someone wants to add kustomizations.

@fabianofranz

fabianofranz commented Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

I think the intent was the -f flag, but -k makes sense in case in the future someone wants to add kustomizations.

Sounds good. Since a kustomization.yaml exists, this will work now already and in future if kustomizations are added.

@acornett21
acornett21 merged commit 77dea01 into docling-project:main Jul 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants