This repository was archived by the owner on May 23, 2019. It is now read-only.
added hacky, ugly, multi path support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| where | ||
| marshallFxn = "var __mrshl = (p:any) => (typeof p === 'array' ? p.join('/') : p.toString())\n" |
There was a problem hiding this comment.
I don't think this test works in every browser. It seems like we should be able to know whether the return value is an array or not since we are creating it.
There was a problem hiding this comment.
Theoretically yes, but it would involve restructuring the code quite a bit. What part do you think wouldn't work in every browser? AFAIK, the ternary operator, .join() and .toString() are standard.
There was a problem hiding this comment.
typeof ... 'array' does not work
…esod-routes-typescript into mc01-added-multippath-support
|
It makes sense to me to not pull this until we need it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gregwebs this is pretty ugly but does create correct typescript code (in our limited test case) that will expect an array for multpiecepathpieces.