feat: upgrade rust edition & add clippy (+ fixes) #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamienVoreiter
changed the title
EQuincerot
reviewed
Dec 15, 2025
Member
EQuincerot
left a comment
EQuincerot
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR!
Just few comments / suggestions / thoughts
Comment on lines
23
to
29
| clippy: | ||
| name: 📎 Clippy - PG 15 | ||
| runs-on: ubuntu-latest | ||
| container: pgxn/pgxn-tools | ||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5 | ||
| - run: cargo clippy --color always --features pg15 |
Member
There was a problem hiding this comment.
Debatable. It was after Test PG15 to spare 5min of build :)
Your way gives a better feedback in Github though
Member
Author
There was a problem hiding this comment.
At the start, I wanted to add clippy for all features but it fails 😭
I tried to only do clippy like you do formatting but it fails
Maybe better to let it as it is, WDYT ?
| } | ||
| fn check_current_node(&mut self, node: *mut Plan, rtables: *mut List) { | ||
| unsafe { | ||
| if node.as_ref().map(|plan_ref| plan_ref.type_) != Some(T_SeqScan) { |
Co-authored-by: Emmanuel Quincerot <[email protected]>
EQuincerot
approved these changes
Dec 15, 2025
Member
EQuincerot
left a comment
EQuincerot
left a comment
There was a problem hiding this comment.
❤️ thanks again for this contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.