Skip to content

fix the increase lock timeout on retry #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CharlesDelannoy merged 5 commits into from
Mar 18, 2025
Merged

fix the increase lock timeout on retry #156

CharlesDelannoy merged 5 commits into from
Mar 18, 2025

Conversation

@CharlesDelannoy
Copy link
Member

@CharlesDelannoy CharlesDelannoy commented Mar 17, 2025 •
edited
Loading

The retrier was modifying the lock_timeout config but:

  • If there was a success the settings might be affected for other migrations
  • the lock_timeout was not really changed on DB side

@CharlesDelannoy CharlesDelannoy self-assigned this Mar 17, 2025
@CharlesDelannoy CharlesDelannoy force-pushed the Fix_lock_timeout_increase branch 8 times, most recently from 4d334b7 to 5630be7 Compare March 17, 2025 17:04
@CharlesDelannoy CharlesDelannoy force-pushed the Fix_lock_timeout_increase branch from 5630be7 to 3afcb87 Compare March 17, 2025 17:10
@CharlesDelannoy CharlesDelannoy force-pushed the Fix_lock_timeout_increase branch from b622e3f to f7ca345 Compare March 17, 2025 17:17
@CharlesDelannoy CharlesDelannoy marked this pull request as ready for review March 17, 2025 17:21
@CharlesDelannoy CharlesDelannoy requested a review from a team as a code owner March 17, 2025 17:21
@CharlesDelannoy CharlesDelannoy merged commit 41b9b69 into master Mar 18, 2025
11 checks passed
@CharlesDelannoy CharlesDelannoy added the bug Something isn't working label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MouadHilali MouadHilali MouadHilali approved these changes

Assignees

@CharlesDelannoy CharlesDelannoy

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CharlesDelannoy @MouadHilali