Merged
Conversation
antoineverin
force-pushed
the
remove-require
branch
from
755b771 to
ecb9587
Compare
bpaquet
previously approved these changes
May 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the provider schema and the corresponding documentation to change the parameters "url" and "token" from required to optional, while specifying default environment variables.
- Updated the documentation in website/docs/index.html.markdown to reflect that "url" and "token" are now optional with default values.
- Modified provider/provider.go to mark "url" and "token" as optional in the provider schema.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website/docs/index.html.markdown | Updated parameter descriptions with default environment variables. |
| provider/provider.go | Changed "url" and "token" from required to optional with defaults. |
Comments suppressed due to low confidence (1)
website/docs/index.html.markdown:43
- There's a spelling mistake: 'ElasticSsearch' should likely be 'Elasticsearch'.
* `token` - (Option) Authentication token to the ElasticSsearch API. Default is `ELASTICSEARCH_API_KEY` environment variable.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bpaquet
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.