Skip to content

Add closure signatures to return phpdoc #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greg0ire merged 1 commit into from
Jan 20, 2026
Merged

Add closure signatures to return phpdoc #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/Expr/ClosureExpressionVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ public static function getObjectFieldValue(object|array $object, string $field):

/**
* Helper for sorting arrays of objects based on multiple fields + orientations.
*
* @return Closure(mixed, mixed): int
*/
public static function sortByField(string $name, int $orientation = 1, Closure|null $next = null): Closure
{
Expand Down Expand Up @@ -171,7 +173,11 @@ public function walkCompositeExpression(CompositeExpression $expr): Closure
};
}

/** @param callable[] $expressions */
/**
* @param array<callable(object): bool> $expressions
*
* @return Closure(object): bool
*/
private function andExpressions(array $expressions): Closure
{
return static fn (object $object): bool => array_all(
Expand All @@ -180,7 +186,11 @@ private function andExpressions(array $expressions): Closure
);
}

/** @param callable[] $expressions */
/**
* @param array<callable(object): bool> $expressions
*
* @return Closure(object): bool
*/
private function orExpressions(array $expressions): Closure
{
return static fn (object $object): bool => array_any(
Expand All @@ -189,7 +199,11 @@ private function orExpressions(array $expressions): Closure
);
}

/** @param callable[] $expressions */
/**
* @param array<callable(object): bool> $expressions
*
* @return Closure(object): bool
*/
private function notExpression(array $expressions): Closure
{
return static fn (object $object) => ! $expressions[0]($object);
Expand Down