Refine return type annotation in Selectable interface for improved type hints for IDE - #551
Merged
Merged
Conversation
Member
|
There is a commit labeled |
Author
Commits squashed now, thanks |
greg0ire
approved these changes
Jul 16, 2026
derrabus
approved these changes
Jul 16, 2026
SenseException
approved these changes
Jul 16, 2026
Member
|
Thanks @dmitryuk ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR fixes the @return annotation of Selectable::matching() to properly propagate generic types (TKey, T) instead of falling back to mixed.
While static analysis tools like PHPStan or Psalm successfully read @phpstan-return and resolve the generics, most IDEs (including PhpStorm and editors using Intelephense) prioritize the standard @return tag.
Also ReadableCollection interface already implements Selectable #314, so no need to set it additionally