fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres#6344
fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres#6344derrabus merged 1 commit intodoctrine:3.9.xfrom susnux:fix/postgres-ipv6-connection
Conversation
|
Thank you for your PR. Please note that we don't merge code changes that are not covered by tests. Is the 3.8.x branch also affected by this bug? If so, please target the 3.8.x branch. |
I have added a test now.
Yes, changed the target. |
|
The Psalm failure is related to your changes. |
Should be fixed now |
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
@derrabus anything I can help with? |
|
Sorry for the delay. I forgot about this one. 😓 |
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
This pull request was closed due to inactivity. |
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
PHPCS and PHPStan need some attention. I can look into this.
Also noticed it and fixed the reported issues, thank you! |
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Alexander M. Turek <me@derrabus.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* 3.9.x: Bump dev tools (doctrine#7002) fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres (doctrine#6344) Run tests on MySQL 9.3 instead of 9.1 (doctrine#7001) CI MariaDB: add 11.8 (doctrine#6991)
* 4.2.x: Ignore new PHPStan errors Bump dev tools (doctrine#7002) fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres (doctrine#6344) Run tests on MySQL 9.3 instead of 9.1 (doctrine#7001) CI MariaDB: add 11.8 (doctrine#6991)
* 4.3.x: phpunit/phpunit (11.5.15 => 11.5.23) (doctrine#7006) Deprecate support for MariaDB 10.5 (doctrine#7000) Fix new and previously ignored PHPStan errors Ignore new PHPStan errors Bump dev tools (doctrine#7002) fix(PgSQL): Allow to pass IPv6 address in URI notation for postgres (doctrine#6344) Run tests on MySQL 9.3 instead of 9.1 (doctrine#7001) CI MariaDB: add 11.8 (doctrine#6991)
3 participants
Summary
Allow to pass IPv6 address of postgres server in URI notation (
[ff:aa:...]).When the host is passed in URI format to
hostparameter ofpg_connectit will fail because it then tries to resolve it as when it was a real host name.Instead just pass the IP address to the
hostaddrparameter.