Rework foreign key constraint introspection on PostgreSQL#6727
Merged
morozov merged 1 commit intodoctrine:5.0.xfrom Jan 17, 2025
Merged
Rework foreign key constraint introspection on PostgreSQL#6727morozov merged 1 commit intodoctrine:5.0.xfrom
morozov merged 1 commit intodoctrine:5.0.xfrom
Conversation
a74ca97 to
f1068e6
Compare
greg0ire
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the existing implementation is that it parses the constraint DDL, so the referenced table name is represented as a SQL expression that needs to be parsed (e.g.
inventory."products").As we're switching to object names represented as value objects, I want to avoid the need to parse this SQL and instead initialize an
OptionallyQualifiedNamefrom two distinct values (the schema name and table name). This is already the case for all other platforms.Additionally, the original implementation likely has these bugs:
"Inventory".products).Subsequently, this unification will allow to remove some boilerplate schema introspection code.
The new implementation is borrowed from PostgreSQL JDBC Driver.
Note that this rework isn't being ported to 4.3.x because this implementation loses the information about whether or not a given name used in the constraint (e.g. column names or the referenced table name) need to be quoted. If there was an integration test that covered a foreign key constraint with columns in the upper case, it would have failed. In a subsequent PR, I will make all introspected names quoted as they are introspected in their natural case, which should be preserved.