Deprecate ForeignKeyConstraint features and introduce ForeignKeyConstraintEditor#6728
Merged
morozov merged 12 commits intodoctrine:4.3.xfrom Jan 20, 2025
Merged
Conversation
morozov
changed the title
morozov
force-pushed
the
foreign-key-constraint-deprecations
branch
2 times, most recently
from
49defcb to
5026606
Compare
It is redundant since doctrine#4804 and loses the information about whether the constraint name is quoted.
morozov
force-pushed
the
foreign-key-constraint-deprecations
branch
2 times, most recently
from
ad4fa5e to
7320288
Compare
morozov
force-pushed
the
foreign-key-constraint-deprecations
branch
from
7320288 to
2631c72
Compare
PhpStorm loses type information about array_shift()'ed elements and doesn't report the usage of deprecated methods. Also, shifting requires non-null assertions even if the count is known.
morozov
force-pushed
the
foreign-key-constraint-deprecations
branch
from
2631c72 to
d6e63e6
Compare
greg0ire
approved these changes
Jan 20, 2025
This was referenced Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the rework started in #6685, now applied to foreign key constraints.